From 6e61fef2254030ee7b225f0c5e2a3dcd206857f3 Mon Sep 17 00:00:00 2001 From: Nathan Adams Date: Wed, 8 Nov 2017 09:20:48 +0100 Subject: [PATCH] Fixed commands with a trailing whitespace --- build.gradle | 2 +- .../java/com/mojang/brigadier/CommandDispatcher.java | 4 +++- .../com/mojang/brigadier/CommandDispatcherTest.java | 10 ++++++++++ 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/build.gradle b/build.gradle index 2d868ad..0b2d68b 100644 --- a/build.gradle +++ b/build.gradle @@ -3,7 +3,7 @@ import groovy.io.FileType apply plugin: 'java-library' apply plugin: 'maven' -version = '0.1.1' +version = '0.1.2' group = 'com.mojang' task wrapper(type: Wrapper) { diff --git a/src/main/java/com/mojang/brigadier/CommandDispatcher.java b/src/main/java/com/mojang/brigadier/CommandDispatcher.java index 5bca273..25193be 100644 --- a/src/main/java/com/mojang/brigadier/CommandDispatcher.java +++ b/src/main/java/com/mojang/brigadier/CommandDispatcher.java @@ -153,7 +153,9 @@ public class CommandDispatcher { context.withCommand(child.getCommand()); if (reader.canRead()) { - reader.skip(); + if (reader.canRead(2)) { + reader.skip(); + } if (child.getRedirect() != null) { final CommandContextBuilder childContext = new CommandContextBuilder<>(this, source, reader.getCursor()); childContext.withNode(child.getRedirect(), new StringRange(reader.getCursor(), reader.getCursor())); diff --git a/src/test/java/com/mojang/brigadier/CommandDispatcherTest.java b/src/test/java/com/mojang/brigadier/CommandDispatcherTest.java index 651dfdd..3352b47 100644 --- a/src/test/java/com/mojang/brigadier/CommandDispatcherTest.java +++ b/src/test/java/com/mojang/brigadier/CommandDispatcherTest.java @@ -173,6 +173,16 @@ public class CommandDispatcherTest { verify(subCommand).run(any(CommandContext.class)); } + @SuppressWarnings("unchecked") + @Test + public void testParseIncomplete() throws Exception { + subject.register(literal("foo").then(literal("bar").executes(command))); + + final ParseResults parse = subject.parse("foo ", source); + assertThat(parse.getReader().getRemaining(), equalTo(" ")); + assertThat(parse.getContext().getNodes().size(), is(1)); + } + @SuppressWarnings("unchecked") @Test public void testExecuteAmbiguiousParentSubcommand() throws Exception {